[libcxx-commits] [PATCH] D76311: [libc++] Do not force the use of -Werror in verify tests

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 26 19:02:47 PDT 2020


ldionne added a comment.

In D76311#1945309 <https://reviews.llvm.org/D76311#1945309>, @MaskRay wrote:

> Just out of curiosity, did you create the patch by writing a script to parse `clang -verify` output and fix the tests automatically?
>  I asked because I had done similar things.


No, I am writing a new test format for libc++ and it wasn't adding that specific warning flag. I noticed the failures of the tests changed by this patch, observed it was because we didn't pass the warning flag, and created this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76311/new/

https://reviews.llvm.org/D76311





More information about the libcxx-commits mailing list