[libcxx-commits] [PATCH] D76798: [libc++] Make sure that temp_directory_path() doesn't return a path with a trailing slash
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Mar 26 10:18:18 PDT 2020
ldionne added a comment.
In D76798#1943906 <https://reviews.llvm.org/D76798#1943906>, @EricWF wrote:
> Lets not start writing tests like this.
> It breaks with the fundamental design goal of the test suite:
> - `c++ test.pass.cpp` should be enough to compile most tests.
> - ./a.out should be enough to run it.
> Please add these tests to `std/input.output/filesystems//fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp`.
First, this test would be a non-standard extension, so it needs to stay in `libcxx/test/libcxx`, not `libcxx/test/std`. And regarding using a `.sh.cpp` instead of a `.pass.cpp`, the only reason is that I wanted to avoid using `::setenv`, which is not standard. But if we're fine with using `::setenv`, then I agree a `.pass.cpp` is a lot simpler.
In D76798#1944023 <https://reviews.llvm.org/D76798#1944023>, @EricWF wrote:
> I don't necessarily agree.
> But if you disagree, I'm willing to proceed with your fix, on the condition that you file a LWG issue about this proposing this behavior as standard.
I replied on the bug report. I think I agree with you but I'd like to clarify a few things. Let's have the discussion on Bugzilla and I'll update this thread with the result of the discussion.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits