[libcxx-commits] [PATCH] D76798: [libc++] Make sure that temp_directory_path() doesn't return a path with a trailing slash

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 26 08:38:59 PDT 2020


EricWF added a comment.
Herald added a subscriber: broadwaylamb.

Lets not start writing tests like this.

It breaks with the fundamental design goal of the test suite:

- `c++ test.pass.cpp` should be enough to compile most tests.
- ./a.out should be enough to run it.

Please add these tests to `std/input.output/filesystems//fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76798/new/

https://reviews.llvm.org/D76798





More information about the libcxx-commits mailing list