[libcxx-commits] [PATCH] D65034: [libc++] use constexpr for sizeof comparisons

[Dimitry Andric via Phabricator via libcxx-commits]

dim added a comment.

FYI FreeBSD is one of the few OSes that enables -Wsystem-headers by default, *and* uses libc++ as its default C++ library.  So we've already submitted a bunch of warning fixes for libc++.

That said, sometimes it is not possible to avoid warnings in libc++ headers, for example when providing deprecated features, but generally pushing and popping the warning state for this works well. Maybe we can use something similar for this.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65034/new/

https://reviews.llvm.org/D65034