[libcxx-commits] [PATCH] D72687: [libcxx] Allow tests to link with static libc++abi/libc++ even if the shared version is present

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 25 14:06:03 PDT 2020


ldionne added a comment.

This broke CMake configuration with the following set of arguments: `-DLLVM_ENABLE_PROJECTS=libcxx -DLIBCXX_ENABLE_SHARED=OFF -DLIBCXX_ENABLE_STATIC=OFF -DLIBCXX_INCLUDE_TESTS=OFF`. Fixed in:

  commit b58902bc72c2b479b5ed27ec0d3422ba9782edbb
  Author: Louis Dionne <ldionne at apple.com>
  Date:   Wed Mar 25 16:50:19 2020 -0400
  
      [libc++] Fix CMake configuration breakage when libc++ is built neither static nor dynamic
  
      Introduced by https://reviews.llvm.org/D72687. This condition can happen
      when the tests are not being run at all, and we're only trying to generate
      the libc++ headers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72687/new/

https://reviews.llvm.org/D72687





More information about the libcxx-commits mailing list