[libcxx-commits] [PATCH] D76256: [libc++] Require the use of clang-verify in .fail.cpp tests that don't fail without it

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 25 14:06:02 PDT 2020

ldionne added a comment.

In D76256#1936998 <https://reviews.llvm.org/D76256#1936998>, @ldionne wrote:

> In D76256#1936968 <https://reviews.llvm.org/D76256#1936968>, @EricWF wrote:
> > > These tests already don't do much on GCC, they just confirm that `-Werror-unused-result` works properly.
> >
> > LGTM if we agree on the `// UNSUPPORTED: gcc` change.
> So, more generally, would you be OK with dropping the notion of `// REQUIRES: verify-support` and instead translate that into `// UNSUPPORTED: gcc`? I believe the best would be to simplify the logic for how we currently determine the `verify-support` feature by just checking whether we're using GCC, but leave `// REQUIRES: verify-support` as that provides more information semantically than `// UNSUPPORTED: gcc`. WDYT? If we're on the same page, I can do that as a follow up change.

I'll check this in as-is and we can talk offline about exactly what you mean by `// UNSUPPORTED: gcc`. Whatever change we make, we should make it for all tests that have `// REQUIRES: verify-support`.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list