[libcxx-commits] [PATCH] D76171: Upstream Bionic definitions of ctype_base/regex.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 25 09:43:32 PDT 2020

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.

I know I've requested it before privately, but I would really love to have publicly available builders that test this configuration. As it stands, no builder at all will test this, so from our perspective this is a no-op.

Comment at: libcxx/include/__locale:502
+    // historical value of the constant is preserved for ABI compatibility.
+    static const mask __regex_word = 0x8000;
At first I wasn't so warm on this change cause of the added complexity, and then I looked at the context around it and I screamed. It's already a mess of platform-specific choices, so I can't reasonably push back on this.

Comment at: libcxx/include/regex:997
 template <class _CharT>
 struct _LIBCPP_TEMPLATE_VIS regex_traits
Do we specialize this class anywhere?

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list