[libcxx-commits] [PATCH] D69314: Bug fix for PR#43703
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 25 09:10:24 PDT 2020
ldionne added a comment.
In D69314#1834674 <https://reviews.llvm.org/D69314#1834674>, @rprichard wrote:
> I tested this patch, and it appears to fix the overflow problem.
> (FWIW, I tested using https://gist.github.com/rprichard/bcff3b3fb0451207dc9f31ccbab938df on Wine and on Windows 10. For both targets, the performance counter frequency was 10MHz, so `counter.QuadPart * nano::den` had previously wrapped around about every 1845 seconds.)
@rprichard Thanks for testing this on Windows. Do you think it's possible to make that test program run for a shorter amount of time so that it can be added to our test suite (i.e. do you think the test would still be relevant if we made it run for a shorter amount of time)?
CHANGES SINCE LAST ACTION
More information about the libcxx-commits