[libcxx-commits] [PATCH] D65034: [libc++] use constexpr for sizeof comparisons

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 25 09:10:14 PDT 2020


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: arichardson.

Looking at this again and the corresponding GCC bug report, I think we should either:

- not fix this issue -- this warning shouldn't bubble up since we mark our headers as system headers, or
- disable `-Wplacement-new` around that code with a `#pragma`, and reference the GCC bug in a comment.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65034/new/

https://reviews.llvm.org/D65034





More information about the libcxx-commits mailing list