[libcxx-commits] [PATCH] D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete

Tue Mar 24 15:06:47 PDT 2020

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: libc++.
This revision now requires review to proceed.

In D75243#1896087 <https://reviews.llvm.org/D75243#1896087>, @EricWF wrote:

> I'm find requiring C++17 to build the dylib, but I'm not sure everyone is?
>
> What is the impact on our compiler support? Surely not all of the currently supported compilers provide -std=c++17?

GCC 5 supports `-std=c++17`, and Clang 4.0 does support `-std=c++1z`. Furthermore, it should be safe to assume a reasonably recent Clang when building the library for serious purposes. For example, it would be surprising for a vendor to build libc++ with an old Clang and ship it.

> I would say land this and see if anybody complains. Maybe add a #if `_LIBCPP_STD_VER < 17` in one of the source files to enforce this?

Will do.

> I'm not sure all the buildbots will tolerate this change, but I'm happy to upgrade or fix those up.

Alright, let's see if it breaks anything, but it shouldn't break the buildbots AFAICT.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75243/new/

https://reviews.llvm.org/D75243