[libcxx-commits] [PATCH] D76731: [libc++] Do not rely on the environment to run filesystem tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added subscribers: libcxx-commits, dexonsmith, jkorous, mgorny.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Previously, filesystem tests would require LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT
to be present in the environment and to match the value provided when
compiling, as a macro. This has the problem that it only allows for the
filesystem tests to be run on the same machine they are created.

Instead, we create a temporary directory for each test. Technically,
this is tricky to do because we're relying on some of the code that
we're testing to do this. However, there's no other portable way of
creating temporary direcories in C++, so this is difficult to avoid.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76731

Files:
  libcxx/test/CMakeLists.txt
  libcxx/test/support/filesystem_dynamic_test_helper.py
  libcxx/test/support/filesystem_test_helper.h
  libcxx/utils/libcxx/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76731.252427.patch
Type: text/x-patch
Size: 6893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200324/a15db0ff/attachment.bin>