[libcxx-commits] [PATCH] D76104: Remove legacy CMake targets for libcxx and libcxxabi
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 23 08:09:42 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf383fb40b17b: Remove legacy CMake targets for libcxx and libcxxabi (authored by ldionne).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76104/new/
https://reviews.llvm.org/D76104
Files:
libcxx/docs/BuildingLibcxx.rst
libcxx/docs/TestingLibcxx.rst
libcxx/include/CMakeLists.txt
libcxx/src/CMakeLists.txt
libcxx/test/CMakeLists.txt
libcxxabi/src/CMakeLists.txt
libcxxabi/test/CMakeLists.txt
Index: libcxxabi/test/CMakeLists.txt
===================================================================
--- libcxxabi/test/CMakeLists.txt
+++ libcxxabi/test/CMakeLists.txt
@@ -81,6 +81,3 @@
${CMAKE_CURRENT_BINARY_DIR}
DEPENDS ${LIBCXXABI_TEST_DEPS}
)
-
-# TODO: This is a legacy target name and should be removed at some point.
-add_custom_target(check-libcxxabi DEPENDS check-cxxabi)
Index: libcxxabi/src/CMakeLists.txt
===================================================================
--- libcxxabi/src/CMakeLists.txt
+++ libcxxabi/src/CMakeLists.txt
@@ -295,7 +295,4 @@
-DCMAKE_INSTALL_COMPONENT=cxxabi
-DCMAKE_INSTALL_DO_STRIP=1
-P "${LIBCXXABI_BINARY_DIR}/cmake_install.cmake")
-
- # TODO: This is a legacy target name and should be removed at some point.
- add_custom_target(install-libcxxabi DEPENDS install-cxxabi)
endif()
Index: libcxx/test/CMakeLists.txt
===================================================================
--- libcxx/test/CMakeLists.txt
+++ libcxx/test/CMakeLists.txt
@@ -83,8 +83,6 @@
"Running libcxx tests"
${CMAKE_CURRENT_BINARY_DIR}
DEPENDS cxx ${LIBCXX_TEST_DEPS})
-
- add_custom_target(check-libcxx DEPENDS check-cxx)
endif()
if (LIBCXX_GENERATE_COVERAGE)
Index: libcxx/src/CMakeLists.txt
===================================================================
--- libcxx/src/CMakeLists.txt
+++ libcxx/src/CMakeLists.txt
@@ -392,5 +392,4 @@
-DCMAKE_INSTALL_COMPONENT=cxx
-DCMAKE_INSTALL_DO_STRIP=1
-P "${LIBCXX_BINARY_DIR}/cmake_install.cmake")
- add_custom_target(install-libcxx DEPENDS install-cxx)
endif()
Index: libcxx/include/CMakeLists.txt
===================================================================
--- libcxx/include/CMakeLists.txt
+++ libcxx/include/CMakeLists.txt
@@ -270,8 +270,5 @@
-P "${CMAKE_BINARY_DIR}/cmake_install.cmake")
# Stripping is a no-op for headers
add_custom_target(install-${CXX_HEADER_TARGET}-stripped DEPENDS install-${CXX_HEADER_TARGET})
-
- add_custom_target(install-libcxx-headers DEPENDS install-${CXX_HEADER_TARGET})
- add_custom_target(install-libcxx-headers-stripped DEPENDS install-${CXX_HEADER_TARGET}-stripped)
endif()
endif()
Index: libcxx/docs/TestingLibcxx.rst
===================================================================
--- libcxx/docs/TestingLibcxx.rst
+++ libcxx/docs/TestingLibcxx.rst
@@ -8,9 +8,9 @@
Getting Started
===============
-libc++ uses LIT to configure and run its tests.
+libc++ uses LIT to configure and run its tests.
-The primary way to run the libc++ tests is by using `make check-libcxx`.
+The primary way to run the libc++ tests is by using `make check-cxx`.
However since libc++ can be used in any number of possible
configurations it is important to customize the way LIT builds and runs
Index: libcxx/docs/BuildingLibcxx.rst
===================================================================
--- libcxx/docs/BuildingLibcxx.rst
+++ libcxx/docs/BuildingLibcxx.rst
@@ -68,7 +68,7 @@
-DLIBCXX_CXX_ABI_INCLUDE_PATHS=path/to/separate/libcxxabi/include \
path/to/llvm-project/libcxx
$ make
- $ make check-libcxx # optional
+ $ make check-cxx # optional
Experimental Support for Windows
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76104.252049.patch
Type: text/x-patch
Size: 3334 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200323/b6e39425/attachment.bin>
More information about the libcxx-commits
mailing list