[libcxx-commits] [PATCH] D76431: Introduce LIBUNWIND_LIT_ARGS, LIBCXXABI_LIT_ARGS and LIBCXX_LIT_AGRS

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake:127
     endif()
-    set(LLVM_LIT_ARGS "${LIT_ARGS_DEFAULT}" CACHE STRING "Default options for lit")
+    if (DEFINED LIBCXX_LIT_ARGS)
+      # libc++-specific LIT args always win over generic LIT args
----------------
ldionne wrote:
> Why isn't that in `libcxx/CMakeLists.txt`?
We were setting `LLVM_LIT_ARGS` here, so I figured that `LIBCXX_LIT_ARGS` should also be set here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76431/new/

https://reviews.llvm.org/D76431