[libcxx-commits] [PATCH] D67900: [libc++] Use builtin type traits whenever possible

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added a comment.

I'll look into the CI failure.



================
Comment at: libcxx/include/type_traits:1161
 
 #if __has_feature(is_enum) || defined(_LIBCPP_COMPILER_GCC)
 
----------------
ldionne wrote:
> `__is_enum` is not guarded by `__has_keyword` like the other ones?
`__is_enum` (and `__underlying_type`) are already being used in the implementation. IIRC early versions of clang only supported `__has_keyword`. But I'm pretty sure we don't support any versions of clang that don't have both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67900/new/

https://reviews.llvm.org/D67900