[libcxx-commits] [PATCH] D76311: [libc++] Do not force the use of -Werror in verify tests
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 18 21:09:21 PDT 2020
ldionne marked 2 inline comments as done.
ldionne added inline comments.
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.modifiers/reset.runtime.fail.cpp:10
+// UNSUPPORTED: c++98, c++03
> Why does this no longer pass?
When adding `-Werror`, we were also adding some specially tailored `-Wno-c++11-extensions` warning suppressor. The problem is that we use `min_allocator.h`, which uses the C++11 extension `= default` even in C++03 mode.
My original workaround was to backport `min_allocator.h` to C++03, but I thought you would prefer just disabling that specific test (`unique_ptr` is supposed to be C++11 anyway).
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits