[libcxx-commits] [PATCH] D62719: A hot fix for exclusive_scan

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm committing this now, sorry it was lost in the weeds. I've made some minor fixes before committing, and I'm documenting them here for completeness.



================
Comment at: test/CMakeLists.txt:26
 
-file(GLOB_RECURSE UNIT_TESTS "*.pass.cpp")
+file(GLOB_RECURSE UNIT_TESTS "*.pass.cpp" "*.fail.cpp")
 foreach(_file IN LISTS UNIT_TESTS)
----------------
This will make the tests fail cause `pstl/` is not using the same lit configuration as libc++, for now it doesn't support fail tests. So I've removed this from the pstl tests, however when the libc++ test suite is run with pstl enabled, the test will be picked up.


================
Comment at: test/std/numerics/numeric.ops/scan.fail.cpp:9
+//===----------------------------------------------------------------------===//
+
+#include <execution>
----------------
Added:

```
// UNSUPPORTED: c++98, c++03, c++11, c++14
```


================
Comment at: test/std/numerics/numeric.ops/scan.fail.cpp:13
+
+struct CustomPolicy {
+
----------------
Ran clang format.


================
Comment at: test/std/numerics/numeric.ops/scan.fail.cpp:25
+
+    std::exclusive_scan(policy, first, last, result, 0);
+    std::exclusive_scan(policy, first, last, result, 0, std::plus<int>());
----------------
Added (twice):
```
// expected-error {{no matching function for call to 'exclusive_scan'}}
```


Repository:
  rPSTL pstl

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62719/new/

https://reviews.llvm.org/D62719