[libcxx-commits] [PATCH] D76150: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings.
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 16 18:03:20 PDT 2020
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In D76150#1922104 <https://reviews.llvm.org/D76150#1922104>, @dim wrote:
> Note: one thing that I am unsure about is the `_NOEXCEPT` after some of the copy constructors. I only applied those to classes that have other `_NOEXCEPT` constructors, but copying may involve other things that could throw.
> Maybe it is safer to not use `_NOEXCEPT` at all for all of them, instead?
I share your concerns. Until very recently Clang diagnosed non-matched exception specifications.
That said, the standard requires these operations not throw so we want to know if the compiler deduces otherwise.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits