[libcxx-commits] [PATCH] D75960: [libc++] Implement C++20's P0476r2: std::bit_cast

[JF Bastien via Phabricator via libcxx-commits]

jfb added inline comments.


================
Comment at: libcxx/test/std/numerics/bit/bit.cast/bit_cast.pass.cpp:164
+        2.71828f, 3.14159f,
+        std::nanf("")
+    };
----------------
Signaling NaN, and NaNs with payloads.
Infinities.
Denormals.

Check this out: https://babbage.cs.qc.cuny.edu/IEEE-754/index.xhtml


================
Comment at: libcxx/test/std/numerics/bit/bit.cast/bit_cast.pass.cpp:194
+        3.141592653589793238462643383279502884197169399375105820974944,
+        std::nanl("")
+    };
----------------
Some of these won't work on all platforms. You'll need to selectively disable some for platforms that don't have IEEE-754 with the expected sizes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75960/new/

https://reviews.llvm.org/D75960