[libcxx-commits] [PATCH] D76092: Allow site-specific test_exec_root.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Mar 13 10:44:30 PDT 2020
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
Herald added a subscriber: dexonsmith.
Comment at: libcxx/test/lit.cfg:41
-config.test_exec_root = os.path.join(obj_root, 'test')
+if not config.test_exec_root:
+ config.test_exec_root = os.path.join(obj_root, 'test')
> ldionne wrote:
> > I haven't come across the `test_exec_root` yet, what is it used for? I grepped but couldn't find out.
> The cwd for compilation is one use. Not sure if there are others. We override this in Android because our obj root (libc++ install location) and the test location is not the same.
Do you have a publicly visible tester that uses this? I'm asking because I'd like to improve the CMake/lit interaction in the coming weeks, and I want to be able to see when I break you.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits