[libcxx-commits] [PATCH] D76092: Allow site-specific test_exec_root.

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 12 17:43:04 PDT 2020


danalbert marked 2 inline comments as done.
danalbert added inline comments.


================
Comment at: libcxx/test/lit.cfg:41
 
-config.test_exec_root = os.path.join(obj_root, 'test')
+if not config.test_exec_root:
+    config.test_exec_root = os.path.join(obj_root, 'test')
----------------
ldionne wrote:
> I haven't come across the `test_exec_root` yet, what is it used for? I grepped but couldn't find out.
The cwd for compilation is one use. Not sure if there are others. We override this in Android because our obj root (libc++ install location) and the test location is not the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76092/new/

https://reviews.llvm.org/D76092





More information about the libcxx-commits mailing list