[libcxx-commits] [PATCH] D76093: Don't expose unavailable cstdio functions.

[Dan Albert via Phabricator via libcxx-commits]

danalbert added inline comments.


================
Comment at: libcxx/include/__config:1550
+// using 64-bit file offsets on LP32.
+#if !defined(__ANDROID__) || !defined(__USE_FILE_OFFSET64) ||                  \
+    (__ANDROID_API__ >= 24)
----------------
ldionne wrote:
> I believe this would be easier to understand if it were instead `_LIBCPP_HAS_NO_FGETPOS`. The condition would become:
> 
> ```
> #if defined(__ANDROID__) && defined(__USE_FILE_OFFSET64) && __ANDROID_API < 24
> ```
> 
> Do you agree?
Yep, SGTM. Also corrected `__ANDROID__` to `__BIONIC__`, not that there are any non-android bionic users old enough (or 32-bit enough) for this to be a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76093/new/

https://reviews.llvm.org/D76093