[libcxx-commits] [PATCH] D63059: Implements multiline regex support

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Mar 12 15:45:24 PDT 2020

ldionne added a comment.

In D63059#1920398 <https://reviews.llvm.org/D63059#1920398>, @Mordante wrote:

> Thanks for the confirmation it's an ABI break. I like your suggestion to use a derived class, so I'll try that solution first.

I'm not 100% sure that solution addresses the ABI break problem, though. I'd have to think about it harder and run it through at least another person to be confident.

Can you comment on that:

> Do we have a way of quantifying how bad it would be? What regexes would be impacted? Is it regexes with ^ or $ used as anchors, passed through ABI boundaries?

If that's an ABI break we can afford to make, it would be great cause it would avoid increasing the code complexity.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list