[libcxx-commits] [PATCH] D75795: [libc++abi] Change __cxa_finalize return type to void

Thu Mar 12 08:40:51 PDT 2020

ldionne requested changes to this revision.
ldionne added a comment.

In D75795#1918579 <https://reviews.llvm.org/D75795#1918579>, @EricWF wrote:

> Even after this patch the declaration is still wrong. Because we mark it with `_LIBCPP_FUNC_VIS`, but the spec specifically says the function should have hidden visibility.
>
> My vote is to remove it.

SGTM, but we could leave a comment saying that `__cxa_finalize` isnt' declared here for <reasons>. AFAICT, `__cxa_atexit` is in the same boat, by the way, so should we remove that one too?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75795/new/

https://reviews.llvm.org/D75795