[libcxx-commits] [PATCH] D75622: [FIX][libc++][Regex] Using regex_constants match_prev_avail | match_not_bol | match_not_bow

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.
Herald added a reviewer: libc++.


================
Comment at: libcxx/test/std/re/re.const/re.matchflag/match_prev_avail.pass.cpp:16
+
+// FIXME: Some examples with word boundary '\b' are failing.
+// Even when not using match_prev_avail or match_not_bow
----------------
Please fix the FIXME.


================
Comment at: libcxx/test/std/re/re.const/re.matchflag/match_prev_avail.pass.cpp:36
+  //Assert that match_prev_avail disables match_not_bow and this matches
+  //assert(regex_match(str1, regex(".*\ba")));
+  //assert(regex_match(str1 + 1, str1 + 2, regex("\ba\b"),
----------------
Why are these commented out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75622/new/

https://reviews.llvm.org/D75622