[libcxx-commits] [PATCH] D75795: [libc++abi] Change __cxa_finalize return type to void
Ryan Prichard via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 11 16:30:12 PDT 2020
rprichard added a comment.
Sorry about this -- I'll try to be more careful in the future about getting my changes vetted.
> @rprichard has no commits to libc++/libc++abi
Pedantic: I do have a couple libcxxabi patches, but @EricWF committed them for me (D36446 <https://reviews.llvm.org/D36446> and D36447 <https://reviews.llvm.org/D36447>).
> Why are we declaring this function at all?
I don't know. `__cxa_finalize` and `__cxa_atexit` are part of the IA-64 C++ ABI, so I suppose the notice at the top of the file applies. They're implemented elsewhere, though, not in libcxxabi.
* This header provides the interface to the C++ ABI as defined at:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits