[libcxx-commits] [PATCH] D75954: Cache uwnind frame headers as they are found.
Jorge Gorbe Moya via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 11 15:33:04 PDT 2020
jgorbe added a comment.
Thanks for doing the extra work of adding a test. Just one final nit.
Comment at: libunwind/test/frameheadercache_test.pass.cpp:2
+// This #if chain is ugly, but see the comments in AddressSpace.hpp for
+// the reasoning.
I think referring to AddressSpace.hpp for the reasoning behind the ugly #ifdef chain is fine, but I'd add a note about the intention. Suggestion:
// Run the test only in configurations where the caching system is used.
// This #if chain...
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits