[libcxx-commits] [PATCH] D62778: [1/2] Add a benchmark for map operations.

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 11 14:42:04 PDT 2020


EricWF requested changes to this revision.
EricWF added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/benchmarks/CartesianBenchmarks.h:22
 struct EnumValue : std::integral_constant<E, static_cast<E>(I)> {
+  static const E value = static_cast<E>(I);
   static std::string name() { return std::string("_") + D::Names[I]; }
----------------
Uh, `EnumValue::value` should already work, since it's inherited from integral constant, no?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62778/new/

https://reviews.llvm.org/D62778





More information about the libcxx-commits mailing list