[libcxx-commits] [PATCH] D75795: [libc++abi] Change __cxa_finalize return type to void

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 11 11:53:16 PDT 2020

ldionne added a comment.

In D75795#1917592 <https://reviews.llvm.org/D75795#1917592>, @MaskRay wrote:

> Howard resigned as the libc++ code owner in "r201432 - Remove myself as owner of libc++". His had one activity on average in recent years. Blocking this patch on his review would create a huge bottleneck.

Just FYI because I think it's interesting -- we do have a private Slack channel where maintainers hang out, and we sometimes ask Howard questions about weird historical stuff. He's always incredibly helpful and often has surprising things to teach us. Of course, we almost never block reviews on his input, but we do reach out when other forms of archeology fail.

> Anyway, I'll sign off from the discussion because we don't need to have it in the first place. I just want to show that I cannot bear an unjustifiable revert,

Indeed, I don't think anything productive is coming out of this discussion, as you don't find my reason for reverting justifiable. There's not much I can do on my end to change that perception.

Judging from your previous reply, it seems clear to me that you were personally offended by my revert. So I apologize for that, that wasn't my intention. My intention was to make sure contributors follow the process that we traditionally have for reviews, even though (as you point out) that process is not textbook the same as documented in the commit guidelines.

> and hope all these misunderstandings will not affect our future collaboration.

Speaking for myself, it will not.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list