[libcxx-commits] [PATCH] D75954: Cache uwnind frame headers as they are found.
Jorge Gorbe Moya via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 11 11:19:16 PDT 2020
jgorbe added a comment.
I think it looks good now. My only issue is that it seems to rely on a couple of glibc-specific features: glibc modifying the fields `adds` and `subs` in `dl_phdr_info` when loading/unloading libraries (which this patch uses to know when to invalidate the cache), and `dl_iterate_phdr` holding a lock (which the patch relies on to avoid races while accessing the cache). What other libc implementations do we support? Do they share these behaviors we rely on here?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits