[libcxx-commits] [PATCH] D75991: [libc++] [cmake] Better diagnostics for missing abi library headers

Wed Mar 11 10:45:58 PDT 2020

ldionne added a comment.

In D75991#1917248 <https://reviews.llvm.org/D75991#1917248>, @broadwaylamb wrote:

> In D75991#1917193 <https://reviews.llvm.org/D75991#1917193>, @ldionne wrote:
>
> > @broadwaylamb I think you might have some funky requirements around that -- would it be problematic for you if we required a monorepo checkout when building libc++ or libc++abi?
>
>
> Honestly, I didn't know that we still supported non-monorepo checkout. On the buildbots I'm working on, I believe this is a non-issue. I can't speak for everyone, though.

Nice. For some reason I thought you had that requirement, and I didn't want to change it without asking cause it would have broken you. I guess I'll ask on libc++-dev just to be sure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75991/new/

https://reviews.llvm.org/D75991