[libcxx-commits] [PATCH] D75954: Cache uwnind frame headers as they are found.
Sterling Augustine via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 11 10:10:38 PDT 2020
saugustine added inline comments.
Comment at: libunwind/src/FrameHeaderCache.hpp:45
+ CacheEntry Entries[kCacheEntryCount];
+ CacheEntry *MostRecentlyUsed;
> Do we need any synchronization here if there are multiple threads?
Good question. We don't because dl_iterate_phdr already holds the load lock and therefore does all the synchronization for us. That isn't obvious at all from reading the code, so adding a comment to that effect.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits