[libcxx-commits] [PATCH] D75991: [libc++] [cmake] Better diagnostics for missing abi library headers

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb created this revision.
Herald added subscribers: libcxx-commits, ldionne, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: libc++.
broadwaylamb edited the summary of this revision.
broadwaylamb added a reviewer: ldionne.
Herald added subscribers: danielkiss, dexonsmith, kristof.beyls.
Herald added a reviewer: mclow.lists.
broadwaylamb edited the summary of this revision.

The main motivation for this change is this build failure <http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/5560/steps/build-llvm-project/logs/stdio>, which for some reason only happens on the buildbot.

This is NFC. We only add additional information to the log.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75991

Files:
  libcxx/cmake/Modules/HandleLibCXXABI.cmake


Index: libcxx/cmake/Modules/HandleLibCXXABI.cmake
===================================================================
--- libcxx/cmake/Modules/HandleLibCXXABI.cmake
+++ libcxx/cmake/Modules/HandleLibCXXABI.cmake
@@ -37,8 +37,10 @@
   foreach(fpath ${LIBCXX_ABILIB_FILES})
     set(found FALSE)
     foreach(incpath ${LIBCXX_CXX_ABI_INCLUDE_PATHS})
+      message(STATUS "Looking for ${fpath} in ${incpath}...")
       if (EXISTS "${incpath}/${fpath}")
         set(found TRUE)
+        message(STATUS "Looking for ${fpath} in ${incpath}... found")
         get_filename_component(dstdir ${fpath} PATH)
         get_filename_component(ifile ${fpath} NAME)
         set(src ${incpath}/${fpath})
@@ -66,10 +68,12 @@
             PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
             )
         endif()
+      else()
+        message(STATUS "Looking for ${fpath} in ${incpath}... not found")
       endif()
     endforeach()
     if (NOT found)
-      message(WARNING "Failed to find ${fpath}")
+      message(WARNING "Failed to find ${fpath} in ${LIBCXX_CXX_ABI_INCLUDE_PATHS}")
     endif()
   endforeach()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75991.249621.patch
Type: text/x-patch
Size: 1123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200311/ce5af8cd/attachment.bin>