[libcxx-commits] [PATCH] D75795: [libc++abi] Change __cxa_finalize return type to void

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 10 15:22:02 PDT 2020

ldionne reopened this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Folks, it's not okay to commit changes to libc++ without having a libc++ or libc++abi code owner review them. If you wait for us to review the change and a review is not coming, you can ping the patch. But you can't commit it just because 2 business days have passed and we haven't said anything.

@MaskRay This isn't the first time this happens. The LLVM community is very loose by giving global commit access to everybody, but we're expecting people to act in good faith and not bypass the usual review process.

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list