[libcxx-commits] [PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting
Leonard Chan via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Mar 10 14:46:26 PDT 2020
leonardchan added a comment.
In D75890#1915493 <https://reviews.llvm.org/D75890#1915493>, @thakis wrote:
> `__FILE__` only expands to an absolute path if you pass an absolute path to clang (ctrl-f "__FILE__" on http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html).
> It feels like this is working around a deficiency in the compiler. Maybe fixing whatever's going wrong in the compiler might be better? (There's also -ffile-file-prefix map, but using that makes your _commandline_ depend on the name of the build dir, and (in clang) `__FILE_NAME__ `.
Using `-ffile-prefix-map` for LLVM builds in general seems to be the better option, but we thought this was simpler since it seemed to only be libunwind that had this non-determinism.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits