[libcxx-commits] [PATCH] D62778: [1/2] Add a benchmark for map operations.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 10 13:06:31 PDT 2020


Mordante requested review of this revision.
Mordante added a comment.

It builds for me, but I had CMAKE_CXX_STANDARD set to 17 for this build. It seems the method used to use C++17 for the benchmarks didn't work. I feel fixing this issue should not be part of this commit. So I created D75955 <https://reviews.llvm.org/D75955> to fix the issue. With that patch applied it also works for me when CMAKE_CXX_STANDARD set to 14. This is the default value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62778/new/

https://reviews.llvm.org/D62778





More information about the libcxx-commits mailing list