[libcxx-commits] [PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 10 12:33:57 PDT 2020


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM but you might want to wait a few more hours for other reviewers to see if anyone has objections.



================
Comment at: libunwind/src/config.h:125
   do {                                                                         \
-    fprintf(stderr, "libunwind: %s %s:%d - %s\n", __func__, __FILE__,          \
-            __LINE__, msg);                                                    \
+    fprintf(stderr, "libunwind: %s - %s\n", __func__, msg);                    \
     fflush(stderr);                                                            \
----------------
I'd consider dropping `__func__` as well but I'm fine with keeping it as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75890/new/

https://reviews.llvm.org/D75890





More information about the libcxx-commits mailing list