[libcxx-commits] [PATCH] D75781: Rework findUnwindSectionsByPhdr to be more optimal.

[Jorge Gorbe Moya via Phabricator via libcxx-commits]

jgorbe added inline comments.


================
Comment at: libunwind/src/AddressSpace.hpp:502
   }
-
-  if (found_obj && found_hdr) {
-    cbdata->sects->dwarf_section_length = object_length;
-    return true;
-  } else {
-    return false;
-  }
+  cbdata->sects->dwarf_section_length = 0;
+  return 0;
----------------
The old code only touches `dwarf_section_length` if both phdrs are found, whereas this patch always resets it to 0 after the loop if it didn't find both. Is this intentional?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75781/new/

https://reviews.llvm.org/D75781