[libcxx-commits] [PATCH] D75692: Lazily save initialState of registers during unwind.
Jorge Gorbe Moya via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Mar 9 15:07:49 PDT 2020
jgorbe added inline comments.
================
Comment at: libunwind/src/DwarfParser.hpp:427
+ // uninitialized data.
+ PrologInfo initialState(false);
----------------
What do you think about making this boolean argument an enum? This call site would be clearer if it was something like
```
// this enumerator is just an example, feel free to use anything better that comes to mind.
PrologInfo initialState(DONT_INITIALIZE);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75692/new/
https://reviews.llvm.org/D75692
More information about the libcxx-commits
mailing list