[libcxx-commits] [PATCH] D74186: Removing *_equality and simplifying comparisons.

Barry Revzin via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Mar 4 09:32:52 PST 2020


BRevzin marked an inline comment as done.
BRevzin added inline comments.


================
Comment at: libcxx/include/compare:72
 enum class _LIBCPP_ENUM_VIS _NCmpResult : signed char {
-  __unordered = -127
+  __unordered = 2
 };
----------------
ldionne wrote:
> Why is this changed to `2`, and why was it `-127` before? Sorry, I'm missing context on the history of this header (which was originally implemented by @EricWF)
It was -127 because that's the exposition-only specification in [cmp].

I changed it to 2 to make it easier to do the comparisons.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74186/new/

https://reviews.llvm.org/D74186





More information about the libcxx-commits mailing list