[libcxx-commits] [PATCH] D73223: Partially inline basic_string copy constructor in UNSTABLE

[Martijn Vels via Phabricator via libcxx-commits]

mvels updated this revision to Diff 248000.
mvels added a comment.

Updated comments, synced with master


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73223/new/

https://reviews.llvm.org/D73223

Files:
  libcxx/include/string


Index: libcxx/include/string
===================================================================
--- libcxx/include/string
+++ libcxx/include/string
@@ -1551,7 +1551,7 @@
 
     // Slow path for the (inlined) copy constructor for 'long' strings.
     // Always externally instantiated and not inlined.
-    // Asserts that __s is zero terminated.
+    // Requires that __s is zero terminated.
     // The main reason for this function to exist is because for unstable, we
     // want to allow inlining of the copy constructor. However, we don't want
     // to call the __init() functions as those are marked as inline which may


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73223.248000.patch
Type: text/x-patch
Size: 630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200303/0bb2aef3/attachment.bin>