[libcxx-commits] [PATCH] D67052: Add reference type transformation builtins
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Mar 1 14:27:59 PST 2020
EricWF added a comment.
LGTM once all of the inline comments are addressed.
After that, this is ready to land.
Comment at: clang/lib/AST/ItaniumMangle.cpp:3412
+ case UnaryTransformType::RemoveReferenceType:
+ Out << "3err";
> Eric, I looked at your comment, but it seems that we no longer unary type transformations that way. @rsmith is this correct?
@rsmith Can you double check the mangling changes?
Comment at: clang/lib/Sema/SemaType.cpp:1624
+ case DeclSpec::TST_removeReferenceType:
+ case DeclSpec::TST_removeCV:
Why can't we share the implementation with `TST_underlyingType`?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits