[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

[Vy Nguyen via Phabricator via libcxx-commits]

oontvoo marked 2 inline comments as done.
oontvoo added a comment.



> This will need test cases. I think we should also consider whether we want to apply this to `shared_ptr` too, as D63748 <https://reviews.llvm.org/D63748>,

Do you have any concern on *not* doing this for `shared_ptr`?

> and if so, whether we want a single configuration macro to apply `[[trivial_abi]]` to both classes, or one macro for each.

One reason that I'd prefer having 2 separate nobs *for now* is because it'd makes it easier to land this into the internal repo :) (We've done a few passes at cleaning up broken things for unique_ptr, but nothing for shared_ptr yet.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490