[libcxx-commits] [PATCH] D82338: [Coroutines] Fix a few failing tests

[Xun Li via Phabricator via libcxx-commits]

lxfind updated this revision to Diff 272772.
lxfind added a comment.

Rebase. Fix two more tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82338/new/

https://reviews.llvm.org/D82338

Files:
  libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
  libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/go.pass.cpp
  libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
  libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp


Index: libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp
===================================================================
--- libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp
+++ libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/oneshot_func.pass.cpp
@@ -25,7 +25,7 @@
     R result;
     func get_return_object() { return {this}; }
     suspend_always initial_suspend() { return {}; }
-    suspend_always final_suspend() { return {}; }
+    suspend_always final_suspend() noexcept { return {}; }
     void return_value(R v) { result = v; }
     void unhandled_exception() {}
   };
Index: libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
===================================================================
--- libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
+++ libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/multishot_func.pass.cpp
@@ -26,7 +26,7 @@
     R result;
     func get_return_object() { return {this}; }
     suspend_always initial_suspend() { return {}; }
-    suspend_never final_suspend() { return {}; }
+    suspend_never final_suspend() noexcept { return {}; }
     void return_void() {}
     template <typename F>
     suspend_always yield_value(F&& f) {
Index: libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/go.pass.cpp
===================================================================
--- libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/go.pass.cpp
+++ libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/go.pass.cpp
@@ -46,9 +46,7 @@
     suspend_never initial_suspend() {
       return {};
     }
-    suspend_never final_suspend() noexcept {
-      return {};
-    }
+    suspend_never final_suspend() noexcept { return {}; }
     void return_void() {}
     goroutine get_return_object() {
       return{};
Index: libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
===================================================================
--- libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
+++ libcxx/test/std/experimental/language.support/support.coroutines/end.to.end/fullexpr-dtor.pass.cpp
@@ -45,7 +45,7 @@
 struct coro2 {
   struct promise_type {
     suspend_never initial_suspend() { return{}; }
-    suspend_never final_suspend() noexcept { return{}; }
+    suspend_never final_suspend() noexcept { return {}; }
     coro2 get_return_object() { return{}; }
     void return_void() {}
     Bug yield_value(int) { return {}; }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82338.272772.patch
Type: text/x-patch
Size: 2790 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200623/b638f824/attachment-0001.bin>