[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind

Tue Jun 23 01:32:49 PDT 2020

broadwaylamb added a comment.

In D70815#2108406 <https://reviews.llvm.org/D70815#2108406>, @raahlb wrote:

> In D70815#1768359 <https://reviews.llvm.org/D70815#1768359>, @mstorsjo wrote:
>
> > I went ahead and reverted this, as it broke how some cmake tests within libunwind work.
> >
> > As this disables linking, it falsely makes any test succeed that depends on linking, and there's a few such tests in cmake/config-ix.cmake (`check_library_exists(c fopen "" LIBUNWIND_HAS_C_LIB)`, `check_library_exists(dl dladdr "" LIBUNWIND_HAS_DL_LIB)`, etc).
> >
> > Therefore, `set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)` has to be carefully placed at a spot where all such tests that does require linking already has been completed.
>
>
> This was fixed in a later commit, correct?

Yep: https://reviews.llvm.org/D71117

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70815/new/

https://reviews.llvm.org/D70815