[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.

Martijn Vels via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jun 19 11:59:03 PDT 2020


mvels added a comment.

In D78763#2104284 <https://reviews.llvm.org/D78763#2104284>, @mvels wrote:

> I'm going to abandon this diff, seems arcanist, phabricator and I can't see each other eye to eye...... :\ which makes me sad,....
>
> Create new diff (same as this) in https://reviews.llvm.org/D82220


And, another 'arcanist suprise' :\

>From a clean local branch: https://reviews.llvm.org/D82221

Abandoning this change, sorry for all the noise, one day I am sure all this will be over and we all will be using plain git and all that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78763/new/

https://reviews.llvm.org/D78763





More information about the libcxx-commits mailing list