[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.
Martijn Vels via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Jun 19 08:38:15 PDT 2020
mvels added a comment.
Looks like harbormaster builds use arcanist, and arcanist has ****magic **** making awful diffs?
For example, I cleanly pulled both my local master and local branch.
git diff against HEAD and origin both confirm the true diff
arc diff --preview gives ....... ******magic******* (https://reviews.llvm.org/differential/diff/272089/)
I have no idea how this all works, or to have phabricator understand / build with a clean full diff against head.....
I'll likely ignore this, if this really breaks build we'll roll back, but does not look like I get any good signal here (and local builds all work fine for me)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78763/new/
https://reviews.llvm.org/D78763
More information about the libcxx-commits
mailing list