[libcxx-commits] [PATCH] D80376: [libc++] [P1208] [C++20] Adopt source location from Library Fundamentals V3 for C++20.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D80376#2100390 <https://reviews.llvm.org/D80376#2100390>, @curdeius wrote:

> Ok, so clang 8 doesn't support `consteval`. It also doesn't have required builtins (`__builtin_FILE` etc.). `consteval` works ok on clang 9+.
>  How can I mark tests as unsupported when the builtins are not supported? (a good example would be column.pass.cpp test that I disabled for gcc that doesn't have `__builtin_COLUMN`)


Can you mark it as unsupported on the specific compiler versions?



================
Comment at: libcxx/test/std/language.support/support.srcloc/obs/column.pass.cpp:10
+// GCC does not have __builtin_COLUMN.
+// UNSUPPORTED: gcc
+
----------------
curdeius wrote:
> Should I use XFAIL instead of UNSUPPORTED so that the test breaks when gcc adds this builtin?
If you use `UNSUPPORTED: gcc-x, gcc-y, gcc-z`, then you won't have this problem. WDYT?

Otherwise, `XFAIL` seems to me like a good idea indeed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80376/new/

https://reviews.llvm.org/D80376