[libcxx-commits] [PATCH] D81770: Modifies the algorithm sort bench. - shows sorting time per element, instead of sorting time per array. This would make comparison between different sizes of arrays easier. - adds std::pair benchmark cases. - uses a large number of arrays to...
Eric Fiselier via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jun 17 14:02:22 PDT 2020
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: libcxx/benchmarks/algorithms.bench.cpp:222
void run(benchmark::State& state) const {
- runOpOnCopies<ValueType>(state, Quantity, Order(), false, [](auto& Copy) {
+ runOpOnCopies<ValueType>(state, Quantity, Order(), true, [](auto& Copy) {
std::make_heap(Copy.begin(), Copy.end());
----------------
Could you make this boolean value an enum, so it's clear what it means?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81770/new/
https://reviews.llvm.org/D81770
More information about the libcxx-commits
mailing list