[libcxx-commits] [PATCH] D81846: [libc++] Allow specifying custom Lit config files

Stephan T. Lavavej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 16 18:38:21 PDT 2020


STL_MSFT added inline comments.


================
Comment at: libcxx/test/lit.cfg.py:7-10
+lit_config.fatal(
+    "You seem to be running Lit directly -- you should be running Lit through "
+    "<build>/bin/llvm-lit, which will ensure that the right Lit configuration "
+    "file is used.")
----------------
I think we started running lit directly as of https://github.com/microsoft/STL/pull/710 so this will affect us - but I am not yet deeply familiar with this area. (Not an objection to your change, thanks for the heads up!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81846/new/

https://reviews.llvm.org/D81846





More information about the libcxx-commits mailing list