[libcxx-commits] [PATCH] D81954: Remove the try/catch codepath if `swap` is `noexcept`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D81954#2096427 <https://reviews.llvm.org/D81954#2096427>, @ldionne wrote:

> In D81954#2096406 <https://reviews.llvm.org/D81954#2096406>, @mpark wrote:
>
> > @ldionne I didn't know we had a mechanism to check codegen. Could you point me to an example?
>
>
> For example `clang/test/CodeGenCXX/blocks-cxx11.cpp` (code <https://github.com/llvm/llvm-project/blob/master/clang/test/CodeGenCXX/blocks-cxx11.cpp>). This would mean adding a dependency on `FileCheck`, but that might be OK anyway. WDYT?


Geez, I'm trying to add the ability to run `FileCheck` inside libc++ tests and it's a pain. Let's not block this fix on that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81954/new/

https://reviews.llvm.org/D81954